[
https://issues.apache.org/jira/browse/YARN-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347387#comment-14347387
]
Li Lu commented on YARN-3264:
-----------------------------
Hi [~vrushalic], thanks for the patch! In general it looks good to me. I have a
few quick questions about it:
# In the following lines:
{code}
+ String tmpRoot =
FileSystemTimelineServiceWriterImpl.TIMELINE_SERVICE_STORAGE_DIR_ROOT;
+ if (tmpRoot == null || tmpRoot.isEmpty()) {
+ tmpRoot = "/tmp/";
+ }
{code}
TIMELINE_SERVICE_STORAGE_DIR_ROOT is defined as final in
FileSystemTimelineServiceWriterImpl (with a not-null initial value), why are we
still checking if it's null here? (Am I missing anything? )
# Why we're removing the abstract keyword for the TimelineAggregator class? I
thought this class was supposed to be abstract?
{code}
-public abstract class TimelineAggregator extends CompositeService {
+public class TimelineAggregator extends CompositeService {
{code}
> [Storage implementation] Create backing storage write interface and a POC
> only file based storage implementation
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-3264
> URL: https://issues.apache.org/jira/browse/YARN-3264
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Vrushali C
> Assignee: Vrushali C
> Attachments: YARN-3264.001.patch, YARN-3264.002.patch,
> YARN-3264.003.patch
>
>
> For the PoC, need to create a backend impl for file based storage of entities
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
