[ 
https://issues.apache.org/jira/browse/YARN-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347626#comment-14347626
 ] 

Li Lu commented on YARN-3264:
-----------------------------

Hi [~vrushalic], thanks for the update. Unfortunately the 
TestTimelineAggregator part failed to compile on my machine, due to the 
abstract TimelineAggregator class. Here, to test the basic features of 
TimelineAggregators, maybe we'd like to set up a SimpleTimelineAggregator class 
that only inherits TimelineAggregator but performs nothing else, and use it in 
TestTimelineAggregator?

Also, I briefly skimmed through the patch and there are some unused imports. 
Maybe we would like to do a final cleanup before it's committed? (It's quite 
simple with an IDE, so let's put that to the final round. ) Thanks! 

> [Storage implementation] Create backing storage write interface and  a POC 
> only file based storage implementation
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3264
>                 URL: https://issues.apache.org/jira/browse/YARN-3264
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Vrushali C
>            Assignee: Vrushali C
>         Attachments: YARN-3264.001.patch, YARN-3264.002.patch, 
> YARN-3264.003.patch, YARN-3264.004.patch
>
>
> For the PoC, need to create a backend impl for file based storage of entities 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to