[ https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350772#comment-14350772 ]
Chuan Liu commented on YARN-2190: --------------------------------- bq. what I meant is if resource != null and knobs are off, it'll pass -1 for the memory and cpu, which is not the same as the original command. With the new 'winutils task' change, negative numbers will meaning no limits. Even without the command line options, the '-1's are still passed to the actual method {{CreateTaskImpl}}. If you look at {{CreateTaskImpl}}, the method will not set the corresponding limit when CPU or memory is negative. > Add CPU and memory limit options to the default container executor for > Windows containers > ----------------------------------------------------------------------------------------- > > Key: YARN-2190 > URL: https://issues.apache.org/jira/browse/YARN-2190 > Project: Hadoop YARN > Issue Type: New Feature > Components: nodemanager > Reporter: Chuan Liu > Assignee: Chuan Liu > Attachments: YARN-2190-prototype.patch, YARN-2190.1.patch, > YARN-2190.10.patch, YARN-2190.11.patch, YARN-2190.12.patch, > YARN-2190.13.patch, YARN-2190.2.patch, YARN-2190.3.patch, YARN-2190.4.patch, > YARN-2190.5.patch, YARN-2190.6.patch, YARN-2190.7.patch, YARN-2190.8.patch, > YARN-2190.9.patch > > > Yarn default container executor on Windows does not set the resource limit on > the containers currently. The memory limit is enforced by a separate > monitoring thread. The container implementation on Windows uses Job Object > right now. The latest Windows (8 or later) API allows CPU and memory limits > on the job objects. We want to add the new options to the executor that can > set the limits on job objects thus provides resource enforcement at OS level. > http://msdn.microsoft.com/en-us/library/windows/desktop/ms686216(v=vs.85).aspx -- This message was sent by Atlassian JIRA (v6.3.4#6332)