Sangjin Lee commented on YARN-3240:

Sorry for chiming in late on this. Thanks [~zjshen] for working on this!

I continue to worry about ATS v.1 and timeline service v.2 getting mixed up. It 
makes me nervous when I see the same class/interface contain code for both. We 
should strive to preserve the state where v.2 can be disabled without affecting 
v.1 whatsoever, and vice versa. We should at least review it very carefully in 
that regard, but it would be good to be able to see it more clearly. Thoughts?

A small nit: PerNodeAggregatorServer and PerNodeAggregatorWebService contain 
wildcard imports.

> [Data Mode] Implement client API to put generic entities
> --------------------------------------------------------
>                 Key: YARN-3240
>                 URL: https://issues.apache.org/jira/browse/YARN-3240
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>             Fix For: YARN-2928
>         Attachments: YARN-3240.1.patch, YARN-3240.2.patch, YARN-3240.3.patch

This message was sent by Atlassian JIRA

Reply via email to