[ 
https://issues.apache.org/jira/browse/YARN-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351856#comment-14351856
 ] 

Junping Du commented on YARN-3296:
----------------------------------

Thanks [~hitesh] for updating the patch!
bq. There is some inconsistency in return values though. Older functions were 
expected to return 0 but cpuPercent returns -1 for cases where functionality is 
not available. 
I think inconsistent for default value here will make user get confused. 
However, I think this shouldn't be in scope of this JIRA and I guess we should 
discuss in a separated JIRA that if we want to change the value (also a 
headache to existing user). 
v2 patch looks good to me. +1. Will commit it later if no further comments from 
others.

> yarn.nodemanager.container-monitor.process-tree.class is configurable but 
> ResourceCalculatorProcessTree class is marked Private
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3296
>                 URL: https://issues.apache.org/jira/browse/YARN-3296
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: YARN-3296.1.patch, YARN-3296.2.patch
>
>
> Given that someone can implement their custom plugin for resource monitoring 
> and configure the NM to use it, this class should be marked public.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to