Jonathan Eagles commented on YARN-3267:

[~lichangleo], this patch looks good in general. A few minor things.

# Please consider changing CheckAcl constructor to take a ugi and remove ugi 
from check method
# Please change CheckAcl variable name tester to checkAcl
# Please cleanup the trailing white space in the patch

> Timelineserver applies the ACL rules after applying the limit on the number 
> of records
> --------------------------------------------------------------------------------------
>                 Key: YARN-3267
>                 URL: https://issues.apache.org/jira/browse/YARN-3267
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Prakash Ramachandran
>            Assignee: Chang Li
>         Attachments: YARN_3267_V1.patch, YARN_3267_V2.patch, 
> YARN_3267_WIP.patch, YARN_3267_WIP1.patch, YARN_3267_WIP2.patch, 
> YARN_3267_WIP3.patch
> While fetching the entities from timelineserver, the limit is applied on the 
> entities to be fetched from leveldb, the ACL filters are applied after this 
> (TimelineDataManager.java::getEntities). 
> this could mean that even if there are entities available which match the 
> query criteria, we could end up not getting any results.

This message was sent by Atlassian JIRA

Reply via email to