Zhijie Shen commented on YARN-2854:

Naga, thanks for the patch. Sorry for not responding you in time. Here're some 
high level comments about the patch:

1. Instead of saying "per-framework information", is it better to say 
"application-specific information"?

2. Current Status is not accurate. It's better to say the current version of 
timeline service is done: core functionality, security and builtin generic 
history service on top it, blah blah. And meanwhile, we're rolling out the 
timeline service next generation to scalable.

3. For the configurations, can we remove 
"yarn.timeline-service.generic-application-history.enabled" or modify the 
description. I know we needs it set to true to enable CLI to get the generic 
history data, but we shouldn't make RM to rely on it  to start sending the 
system metrics.

4. The bellow configs are more like the advanced configs.
76      | `yarn.timeline-service.ttl-enable` | Enable age off of timeline store 
data. Defaults to true. |
77      | `yarn.timeline-service.ttl-ms` | Time to live for timeline store data 
in milliseconds. Defaults to 604800000 (7 days). |
78      | `yarn.timeline-service.handler-thread-count` | Handler thread count 
to serve the client RPC requests. Defaults to 10. |
79      | `yarn.timeline-service.client.max-retries` | Default maximum number 
of retires for timeline servive client. Defaults to 30. |
80      | `yarn.timeline-service.client.retry-interval-ms` | Default retry time 
interval for timeline servive client. Defaults to 1000. |

5. Can we rephrase the following sentence. "Enabling the timeline service and 
the generic history service"?
        #### Sample configuration for enabling Application History service and 
per-framework data by applications

> The document about timeline service and generic service needs to be updated
> ---------------------------------------------------------------------------
>                 Key: YARN-2854
>                 URL: https://issues.apache.org/jira/browse/YARN-2854
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: TimelineServer.html, YARN-2854.20141120-1.patch, 
> YARN-2854.20150128.1.patch, YARN-2854.20150304.1.patch, timeline_structure.jpg

This message was sent by Atlassian JIRA

Reply via email to