Naganarasimha G R commented on YARN-2495:

bq. It's just that I don't like this areNodeLabelsSetInReq flag in the 
protocol. Are there other ways of achieving this?
Other way out is always send the set of labels as part of every heartbeat. We 
wanted to avoid this traffic, hence initially we came up with this approach 
when we were supporting multiple labels for a node (may be in future we might 
support multiple labels again right ?)

{{I think treating invalid labels as a disaster case will be, well, a 
disaster.}} : liked the sentence :)

bq. How about we let the node run (just like we let an unhealthy node run) and 
report it in the diagnostics? I'm okay keeping that same behavior during 
registration too.
Yes this is similar to the earlier behavior we had in the Dec's patch , 
Additionally to inform back the failure, we had  added one flag to inform NM 
whether RM accepted the labels or not and Diag Message was also set with 
appropriate message. Whether this approach is fine ?

> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, 
> YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch, 
> YARN-2495.20141119-1.patch, YARN-2495.20141126-1.patch, 
> YARN-2495.20141204-1.patch, YARN-2495.20141208-1.patch, 
> YARN-2495.20150305-1.patch, YARN-2495.20150309-1.patch, 
> YARN-2495_20141022.1.patch
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml (YARN-2923) or 
> using script suggested by [~aw] (YARN-2729) )
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels

This message was sent by Atlassian JIRA

Reply via email to