[
https://issues.apache.org/jira/browse/YARN-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358163#comment-14358163
]
Jian He commented on YARN-3248:
-------------------------------
thanks Varun ! some comments on the patch:
- one question is that should the blacklisted info be in
attemptInfo/attemptReport or appInfo/applicationReport; Given that different
attempts can specify different set of blacklisted nodes, I think it should be
attempt specific. And now that the attempt page is introduced, we may put the
blacklist info in the attempt page?
- the following should be inside the previous allowAccess check;
{code}
Set<String> blacklistedNodes = null;
if (scheduler instanceof AbstractYarnScheduler
&& currentApplicationAttemptId != null
&& createApplicationState().equals(YarnApplicationState.RUNNING)) {
blacklistedNodes =
((AbstractYarnScheduler) scheduler).getApplicationAttempt(
currentApplicationAttemptId).getBlacklistedNodes();
}
{code}
- add unstable annotation for now to the newly added APIs
- the blacklisted info now is lost if application completes. we may update the
black listed info in the RMAppAttemptMetrics too so that the backlisted list
info continue to exist even if app finishes.
- I think we should return the blacklisted info regardless of the application
state.
{code}
if (state.equals(YarnApplicationState.RUNNING)) {
{code}
> Display count of nodes blacklisted by apps in the web UI
> --------------------------------------------------------
>
> Key: YARN-3248
> URL: https://issues.apache.org/jira/browse/YARN-3248
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacityscheduler, resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: All applications.png, App page.png, Screenshot.jpg,
> apache-yarn-3248.0.patch, apache-yarn-3248.1.patch, apache-yarn-3248.2.patch,
> apache-yarn-3248.3.patch
>
>
> It would be really useful when debugging app performance and failure issues
> to get a count of the nodes blacklisted by individual apps displayed in the
> web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
