[ 
https://issues.apache.org/jira/browse/YARN-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359012#comment-14359012
 ] 

Sangjin Lee commented on YARN-3034:
-----------------------------------

The hadoop jenkins would try to apply it against the trunk, so it wouldn't pass 
anyway.

I took a look at the patch, and it looks good for the most part. One minor 
comment:

- resourcemanager/pom.xml
  -- you should be able to remove the version as it is specified in the parent 
pom
  -- nit: reduce spaces to 2

Thanks!

> [Aggregator wireup] Implement RM starting its ATS writer
> --------------------------------------------------------
>
>                 Key: YARN-3034
>                 URL: https://issues.apache.org/jira/browse/YARN-3034
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3034-20150312-1.patch, YARN-3034.20150205-1.patch
>
>
> Per design in YARN-2928, implement resource managers starting their own ATS 
> writers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to