Junping Du commented on YARN-3039:

bq. Yes, I get the reasoning for annotating individual methods. My concern is 
more about the new classes. Note that we're still evolving even the class 
names. This might be a fine point, but I feel we should annotate the new 
classes at least as unstable for now in addition to the method annotations. 
Agree. I think in v5 patch, I tried to mark all interfaces (include some 
abstract classes, we don't need to mark implementation because it follow the 
same with parent class/interface) with either Evolving or Unstable. Please let 
me know if I miss something there.

bq. So you mean it will be backward compatible, right?
Yes. I mean this.

bq. NM doesn't know the RPC port for the per-all collector in the special 
container until ... the special containers tells it. This is not a problem with 
the current per-node collector container situation.
Make sense. That's also a good reason to keep NM as RPC server and 
aggregator(collector)Collection as client.

> [Aggregator wireup] Implement ATS app-appgregator service discovery
> -------------------------------------------------------------------
>                 Key: YARN-3039
>                 URL: https://issues.apache.org/jira/browse/YARN-3039
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: Service Binding for applicationaggregator of ATS 
> (draft).pdf, Service Discovery For Application Aggregator of ATS (v2).pdf, 
> YARN-3039-no-test.patch, YARN-3039-v2-incomplete.patch, 
> YARN-3039-v3-core-changes-only.patch, YARN-3039-v4.patch, YARN-3039-v5.patch
> Per design in YARN-2928, implement ATS writer service discovery. This is 
> essential for off-node clients to send writes to the right ATS writer. This 
> should also handle the case of AM failures.

This message was sent by Atlassian JIRA

Reply via email to