Naganarasimha G R updated YARN-2495:
    Attachment: YARN-2495.20150318-1.patch

Hi [~wangda], 
Thanks for finalizing the solution ,
+1 for use of {{NodeIdToLabelsProto}},  i have incorporated this in the patch 
but ensured that interface will have set and get NodeLabels in 
NodeHeartbeatRequest and RegisterNodeManagerRequest but manipulate in PBImpl's 
such that NodeIdToLabelsProto is communicated across. So NodeLabelsSet will be 
null if no labels are sent across.

+1 for handling of "Regarding the invalid node label issue of 
registration/hearbeating" , Making the node labels empty will ensure that based 
on old labels, scheduler will not wrongly allocate.  But as part of this patch 
will be only handling the logging of invalid labels in NM and RM. WebUI 
updation and setting the node labels empty will be handled as part of  new 
jira, as this jira is becoming bulkier

I have incorporated other review comments (including the NM and 
NodeStatusUpdateImpl modifications wrt Wangda's comments)

> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, 
> YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch, 
> YARN-2495.20141119-1.patch, YARN-2495.20141126-1.patch, 
> YARN-2495.20141204-1.patch, YARN-2495.20141208-1.patch, 
> YARN-2495.20150305-1.patch, YARN-2495.20150309-1.patch, 
> YARN-2495.20150318-1.patch, YARN-2495_20141022.1.patch
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml (YARN-2923) or 
> using script suggested by [~aw] (YARN-2729) )
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels

This message was sent by Atlassian JIRA

Reply via email to