Wangda Tan commented on YARN-2693:

Some overall suggestions:
1) Instead of ApplicationPriorityPerQueue, queue's priority related fields 
could store in scheduler.Queue directly (methods of scheduler.Queue, 
implementation for different scheduler could be various. Since we have 
different scheduler configuration). Benefits of doing this:
- All other queue-specifc configurations are in schedulers' own configuration 
files, make application-priority fields for queue storing out-of queue means 
you have to sync it with queue's configuration when you do refreshQueues, etc.
- Put it in scheduler.Queue can make scheduler changes easier (don't have to 
access ApplicationPriorityManager).

2) Methods of ApplicationPriorityManager:
- Since we're discussing how to configure priority, I will review 
ApplicationPriorityManager implementations once we close design.
- "ClusterPriorities" should be a range (If we start from zero, a "maxPriority" 
will be enough)
- getApplicationPriorityFromQueue should not exist, all queue related methods 
should be in scheduler.Queue
- "isPriorityExistsInCluster" maybe not "existed", it should be something like 
- Can be reinitialize
- Can convert between number/label

> Priority Label Manager in RM to manage application priority based on 
> configuration
> ----------------------------------------------------------------------------------
>                 Key: YARN-2693
>                 URL: https://issues.apache.org/jira/browse/YARN-2693
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-2693.patch, 0002-YARN-2693.patch, 
> 0003-YARN-2693.patch, 0004-YARN-2693.patch, 0005-YARN-2693.patch, 
> 0006-YARN-2693.patch
> Focus of this JIRA is to have a centralized service to handle priority labels.
> Support operations such as
> * Add/Delete priority label to a specified queue
> * Manage integer mapping associated with each priority label
> * Support managing default priority label of a given queue
> * Expose interface to RM to validate priority label
> TO have simplified interface, Priority Manager will support only 
> configuration file in contrast with admin cli and REST. 

This message was sent by Atlassian JIRA

Reply via email to