Wangda Tan commented on YARN-2495:

Thanks for updating.

1. I saw you're trying to make {{repeat string nodeLabels}} to be 3 different 
values: null, empty, and non-empty. But I'm not sure if this works in PB, could 
you write a test to verify that? (Not-set/Set-nothing/Set-value to 
RegisterNodeManagerRequestPBImpl.nodeLabels, create a new 
RegisterNodeManagerRequestPBImpl from old.getProto(), and get nodeLabels() to 
see if it works).

If this doesn't work, you can create a PB message like StringSetProto use it in 
messages like RegisterNodeManagerRequest, which can support null/empty/non-empty

2. Typo, lable -> label, I found several in your patch.

3. optional bool areNodeLablesAcceptedByRM = 7 \[default = false\], I think 
default should be true.

4. NodeStatusUpdaterImpl: no need to call nodeLabelsProvider.getNodeLabels() 
twice when register/heartbeat

5. HeartBeat -> Heartbeat

6. NodeStatusUpdaterImpl: When labels are rejected by RM, you should log it 
with diag message.

Will include test review in next round.

> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, 
> YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch, 
> YARN-2495.20141119-1.patch, YARN-2495.20141126-1.patch, 
> YARN-2495.20141204-1.patch, YARN-2495.20141208-1.patch, 
> YARN-2495.20150305-1.patch, YARN-2495.20150309-1.patch, 
> YARN-2495.20150318-1.patch, YARN-2495_20141022.1.patch
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml (YARN-2923) or 
> using script suggested by [~aw] (YARN-2729) )
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels

This message was sent by Atlassian JIRA

Reply via email to