[ 
https://issues.apache.org/jira/browse/YARN-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366514#comment-14366514
 ] 

Zhijie Shen commented on YARN-3047:
-----------------------------------

Some comments about the patch:

1. No need to change {{timeline/TimelineEvents.java}}.

2. In YarnConfiguration, how about we still reusing the existing timeline 
service config. I propose config reuse because there doesn't exist the use case 
that we start old timeline server and the new timeline reader server together. 
And change in WebAppUtils should be not necessary too.

3. NameValuePair is for internal usage only. Let's keep it in the timeline 
service module?

4. Rename TimelineReaderStore to TimelineReader. I think we don't need to have 
NullTimelineReader. Instead, we should have a POC implementation based on local 
FS like FileSystemTimelineWriterImpl. But we can defer this work in a separate 
jira if the implementation is not straightforward.

5. TimelineReaderServer -> TimelineWebServer? For startTimelineReaderWebApp, 
can we do something similar to TimelineAggregatorsCollection#startWebApp.

6. Add the command in yarn and yarn.cmd to start the server.

> [Data Serving] Set up ATS reader with basic request serving structure and 
> lifecycle
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-3047
>                 URL: https://issues.apache.org/jira/browse/YARN-3047
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-3047.001.patch, YARN-3047.02.patch
>
>
> Per design in YARN-2938, set up the ATS reader as a service and implement the 
> basic structure as a service. It includes lifecycle management, request 
> serving, and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to