[ 
https://issues.apache.org/jira/browse/YARN-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369544#comment-14369544
 ] 

Junping Du commented on YARN-3333:
----------------------------------

Thanks [~sjlee0] for delivering an updated patch! 
+1. v2 patch (big but straightforward) LGTM. Agree that we can fix a test 
failure separately. 
I will go ahead to commit it quickly if no further comments as this patch block 
all other works ongoing.

> rename TimelineAggregator etc. to TimelineCollector
> ---------------------------------------------------
>
>                 Key: YARN-3333
>                 URL: https://issues.apache.org/jira/browse/YARN-3333
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: YARN-3333-unit-tests-fixes.patch, YARN-3333.001.patch, 
> YARN-3333.002.patch
>
>
> Per discussions on YARN-2928, let's rename TimelineAggregator, etc. to 
> TimelineCollector, etc.
> There are also several minor issues on the current branch, which can be fixed 
> as part of this:
> - fixing some imports
> - missing license in TestTimelineServerClientIntegration.java
> - whitespaces
> - missing direct dependency



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to