Wangda Tan commented on YARN-2495:

Go through patch again, hopefully this is last round from my side :)

1) StringArrayProto.stringElement -> elements

2) After thought, I think {{optional bool areNodeLabelsAcceptedByRM = 7 
\[default = false\];}} should be true to be more defensive: We need make sure 
there's no error when somebody forget to set this field.

3) testNodeHeartbeatRequestPBImplWithNullLabels: remove 
{{original.setNodeLabels(null);}}, test should still pass.

4) NodeLabelsProviderService -> NodeLabelsProvider, like most other modules, we 
don't need to make "service" as a part of the classname, change sub classes and 
NodeManager.createNodeLabelsProviderService as well.

5) NodeStatusUpdaterImpl.run:
617             int lastHeartbeatID = 0;
618             Set<String> nodeLabelsLastUpdatedToRM = null;
619             if (hasNodeLabelsProvider) {
No matter if hasNodeLabelsProvider, nodeLabelsLastUpdatedToRM should be null? 
By default is "not change" instead of "empty", correct?

6) nodeLabelsLastUpdatedToRM -> lastUpdatedNodeLabelsToRM

7) areNodeLabelsUpdated: Need check null? And could you add more test to cover 
the case when new fetched node labels and/or last node labels are null?

> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, 
> YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch, 
> YARN-2495.20141119-1.patch, YARN-2495.20141126-1.patch, 
> YARN-2495.20141204-1.patch, YARN-2495.20141208-1.patch, 
> YARN-2495.20150305-1.patch, YARN-2495.20150309-1.patch, 
> YARN-2495.20150318-1.patch, YARN-2495.20150320-1.patch, 
> YARN-2495_20141022.1.patch
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml (YARN-2923) or 
> using script suggested by [~aw] (YARN-2729) )
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels

This message was sent by Atlassian JIRA

Reply via email to