Jian He commented on YARN-3294:

Thanks for updating the patch, looks good overall, 
- how about passing the ‘logHierarchy’ as a parameter too ? so that the web 
service also work for user-provided class name, may be also take in 
dumpLocation as a parameter too ?
   @Produces({ MediaType.APPLICATION_JSON, MediaType.APPLICATION_XML })

    public String dumpSchedulerLogs(String time) throws IOException {
- question - wondering whether we need the “@QueryParam” for the 'time' 
parameter, as other some other places in the same file do, e.g. getApps;
- if no permission for RM to write logs, will the webService throw error ?
- {{new File(System.getProperty("hadoop.log.dir"), targetFilename);}}, should 
this be “yarn.log.dir” ?
- {{return "Capacity scheduler logs are being created.";}} it should probably 
return JAXB formatted response. The response seems broken if I directly access 
the web service from my browser
- AdHocLogDumper#appenderLevels - entry is never removed from the map, is this 

> Allow dumping of Capacity Scheduler debug logs via web UI for a fixed time 
> period
> ---------------------------------------------------------------------------------
>                 Key: YARN-3294
>                 URL: https://issues.apache.org/jira/browse/YARN-3294
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacityscheduler
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: Screen Shot 2015-03-12 at 8.51.25 PM.png, 
> apache-yarn-3294.0.patch, apache-yarn-3294.1.patch, apache-yarn-3294.2.patch, 
> apache-yarn-3294.3.patch
> It would be nice to have a button on the web UI that would allow dumping of 
> debug logs for just the capacity scheduler for a fixed period of time(1 min, 
> 5 min or so) in a separate log file. It would be useful when debugging 
> scheduler behavior without affecting the rest of the resourcemanager.

This message was sent by Atlassian JIRA

Reply via email to