[
https://issues.apache.org/jira/browse/YARN-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372389#comment-14372389
]
zhihai xu commented on YARN-3241:
---------------------------------
Hi [~kasha], many thanks for the review. These are very good suggestions. I
uploaded a new patch YARN-3241.002.patch, which addressed all your comments.
Please review it.
> Leading space, trailing space and empty sub queue name may cause
> MetricsException for fair scheduler
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-3241
> URL: https://issues.apache.org/jira/browse/YARN-3241
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: YARN-3241.000.patch, YARN-3241.001.patch,
> YARN-3241.002.patch
>
>
> Leading space, trailing space and empty sub queue name may cause
> MetricsException(Metrics source XXX already exists! ) when add application to
> FairScheduler.
> The reason is because QueueMetrics parse the queue name different from the
> QueueManager.
> QueueMetrics use Q_SPLITTER to parse queue name, it will remove Leading space
> and trailing space in the sub queue name, It will also remove empty sub queue
> name.
> {code}
> static final Splitter Q_SPLITTER =
> Splitter.on('.').omitEmptyStrings().trimResults();
> {code}
> But QueueManager won't remove Leading space, trailing space and empty sub
> queue name.
> This will cause out of sync between FSQueue and FSQueueMetrics.
> QueueManager will think two queue names are different so it will try to
> create a new queue.
> But FSQueueMetrics will treat these two queue names as same queue which will
> create "Metrics source XXX already exists!" MetricsException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
