[
https://issues.apache.org/jira/browse/YARN-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372515#comment-14372515
]
Chengbing Liu commented on YARN-3024:
-------------------------------------
[~kasha], I think we should use {{==}} for enum members, for it is both null
safe and it saves a function call.
The TODOs were there before this patch. Previously there were 5 TODOs. I did
some refactoring to remove the duplicated code, and now there are 3. Would you
like me to create JIRAs to follow the issue?
> LocalizerRunner should give DIE action when all resources are localized
> -----------------------------------------------------------------------
>
> Key: YARN-3024
> URL: https://issues.apache.org/jira/browse/YARN-3024
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.6.0
> Reporter: Chengbing Liu
> Assignee: Chengbing Liu
> Fix For: 2.7.0
>
> Attachments: YARN-3024.01.patch, YARN-3024.02.patch,
> YARN-3024.03.patch, YARN-3024.04.patch
>
>
> We have observed that {{LocalizerRunner}} always gives a LIVE action at the
> end of localization process.
> The problem is {{findNextResource()}} can return null even when {{pending}}
> was not empty prior to the call. This method removes localized resources from
> {{pending}}, therefore we should check the return value, and gives DIE action
> when it returns null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
