Junping Du commented on YARN-3034:

Thanks [~Naganarasimha] for updating the patch!
bq.  Also, we should add a warning message log if user put something illegal 
here or it just get silent without any warn. This i feel is not required as we 
don't do this for any other configuration and also we have clearly captured the 
possible values in the yarn-default.xml.
Most configurations get loaded as boolean value or int number. Some String 
configuration is for loading class, so ClassNotFound will get throw immediately 
if name is wrong. Here it belongs a different case, so I still suggest to add 
some check and warning here.

For context info, [~zjshen], can we put that work on your patch in YARN-3040? 
Or you suggest something else? 

> [Collector wireup] Implement RM starting its timeline collector
> ---------------------------------------------------------------
>                 Key: YARN-3034
>                 URL: https://issues.apache.org/jira/browse/YARN-3034
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3034-20150312-1.patch, YARN-3034.20150205-1.patch, 
> YARN-3034.20150316-1.patch, YARN-3034.20150318-1.patch, 
> YARN-3034.20150320-1.patch
> Per design in YARN-2928, implement resource managers starting their own ATS 
> writers.

This message was sent by Atlassian JIRA

Reply via email to