[ 
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377133#comment-14377133
 ] 

Hadoop QA commented on YARN-3393:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12706792/YARN-3393.1.patch
  against trunk revision 2c238ae.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/7084//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7084//console

This message is automatically generated.

> Getting application(s) goes wrong when app finishes before starting the 
> attempt
> -------------------------------------------------------------------------------
>
>                 Key: YARN-3393
>                 URL: https://issues.apache.org/jira/browse/YARN-3393
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>            Priority: Critical
>         Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it 
> checks if appAttempt == null.
> {code}
>         ApplicationAttemptReport appAttempt = 
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
>         if (appAttempt != null) {
>           app.appReport.setHost(appAttempt.getHost());
>           app.appReport.setRpcPort(appAttempt.getRpcPort());
>           app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>           
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
>         }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws 
> ApplicationAttemptNotFoundException:
> {code}
>     if (entity == null) {
>       throw new ApplicationAttemptNotFoundException(
>           "The entity for application attempt " + appAttemptId +
>           " doesn't exist in the timeline store");
>     } else {
>       return convertToApplicationAttemptReport(entity);
>     }
> {code}
> They code isn't coupled well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to