Bartosz Ługowski commented on YARN-1621:

Thanks [~Naganarasimha].

Done all, apart of:

* May be we can leverage the benifit of passing the states to AHS too, this 
will reduce the transfer of data from AHS to the client. ur opinion ?
* If we are incorporating the above point then i feel only only when 
appNotFoundInRM we need to query for all states from AHS if not querying for 
COMPLETE state would be sufficient.
Correct me if I'm wrong, but AHS has only COMPLETE containers, so we need to 
query AHS only if states filter is empty(ALL) or contains COMPLETE state.
* No test cases for modification of 
There are already tests for this in: 
org.apache.hadoop.yarn.api.TestPBImplRecords#testGetContainersRequestPBImpl ?
* there are some test case failures and findbugs issues reported can you take a 
look at it
Not related with this patch.

> Add CLI to list rows of <task attempt ID, container ID, host of container, 
> state of container>
> ----------------------------------------------------------------------------------------------
>                 Key: YARN-1621
>                 URL: https://issues.apache.org/jira/browse/YARN-1621
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Tassapol Athiapinya
>            Assignee: Bartosz Ługowski
>         Attachments: YARN-1621.1.patch, YARN-1621.2.patch, YARN-1621.3.patch, 
> YARN-1621.4.patch, YARN-1621.5.patch, YARN-1621.6.patch
> As more applications are moved to YARN, we need generic CLI to list rows of 
> <task attempt ID, container ID, host of container, state of container>. Today 
> if YARN application running in a container does hang, there is no way to find 
> out more info because a user does not know where each attempt is running in.
> For each running application, it is useful to differentiate between 
> running/succeeded/failed/killed containers.
> {code:title=proposed yarn cli}
> $ yarn application -list-containers -applicationId <appId> [-containerState 
> <state of container>]
> where containerState is optional filter to list container in given state only.
> <container state> can be running/succeeded/killed/failed/all.
> A user can specify more than one container state at once e.g. KILLED,FAILED.
> <task attempt ID> <container ID> <host of container> <state of container> 
> {code}
> CLI should work with running application/completed application. If a 
> container runs many task attempts, all attempts should be shown. That will 
> likely be the case of Tez container-reuse application.

This message was sent by Atlassian JIRA

Reply via email to