Junping Du commented on YARN-3040:

Thanks [~zjshen] for updating the patch!
bq. I also agree "yarn.cluster.id" sounds better, but 
"yarn.resourcemanager.cluster-id" is the legacy name, which is used by RM HA 
for a while. As it's not sound so bad, how about keeping it, such that we don't 
need to deprecate config or break compatibility.
Yes. It should be fine if we are reusing the "yarn.resourcemanager.cluster-id". 
Raising a question here is: it looks like we don't set any default value to 
"yarn.resourcemanager.cluster-id" in HA case and YARN will complain the value 
not set properly in HA service. Do we need to follow that practice? I guess no 
but just raising it for attention.

v4 patch looks pretty good to me. If no concern on issue above or other further 
comments, I will go ahead to commit it later.

> [Data Model] Make putEntities operation be aware of the app's context
> ---------------------------------------------------------------------
>                 Key: YARN-3040
>                 URL: https://issues.apache.org/jira/browse/YARN-3040
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Zhijie Shen
>         Attachments: YARN-3040.1.patch, YARN-3040.2.patch, YARN-3040.3.patch, 
> YARN-3040.4.patch
> Per design in YARN-2928, implement client-side API for handling *flows*. 
> Frameworks should be able to define and pass in all attributes of flows and 
> flow runs to YARN, and they should be passed into ATS writers.
> YARN tags were discussed as a way to handle this piece of information.

This message was sent by Atlassian JIRA

Reply via email to