Naganarasimha G R commented on YARN-3044:

Thanks [~vrushalic], for reviewing it
bq. moving the code across packages may break software which is importing these.
Well the classes which are being moved are very much private to the System 
metrics publisher(event classes ) and are not exposed outside. So as the same 
set of events will be used by RM timeline collector i have moved it out, which 
i feel should be fine. may be [~zjshen] and [~sjlee0] can also opine on the 

bq. I think we should be supporting all states as given in 
org.apache.hadoop.yarn.api.records.YarnApplicationState, no?
Well i too had the same doubt whether we need to capture very minute part of 
the life cycle events as present in the RMAppState(/YarnApplicationState) and 
RMAppAttemptState. That is the reason i had posted earlier but [~sjlee0] had 
opined to start of with the basic ones hence provided this patch. Based on the 
input from all will add other required states

> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>                 Key: YARN-3044
>                 URL: https://issues.apache.org/jira/browse/YARN-3044
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3044.20150325-1.patch
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.

This message was sent by Atlassian JIRA

Reply via email to