[
https://issues.apache.org/jira/browse/YARN-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380781#comment-14380781
]
Vinod Kumar Vavilapalli commented on YARN-3365:
-----------------------------------------------
Quick comments on the patch
- operations.RUN_AS_USER_INITIALIZE_CONTAINER -> INITIALIZE_CONTAINER_AS_USER?
Similarly other operations?
- Looked in isolation, TC seems like an inside abbreviation. Let's be verbose
in code and say traffic-control everywhere?
- Move all tc related code to new files (seeing as we are going to keep adding
more resources in the near future)?
- cmd_input.hierarchy -> cgroups_hierarchy. cmd_input.command_file ->
tc_command_file.
- Test case: Use application.submitter instead of user.name for the non-secure
local-user?
- //kill me now.
Sure, but later :)
Explain a little on what the command-file contains? May be an example here on
JIRA as to how NodeManager will use the tc command will help.
> Add support for using the 'tc' tool via container-executor
> ----------------------------------------------------------
>
> Key: YARN-3365
> URL: https://issues.apache.org/jira/browse/YARN-3365
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-3365.001.patch, YARN-3365.002.patch
>
>
> We need the following functionality :
> 1) modify network interface traffic shaping rules - to be able to attach a
> qdisc, create child classes etc
> 2) read existing rules in place
> 3) read stats for the various classes
> Using tc requires elevated privileges - hence this functionality is to be
> made available via container-executor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
