[ 
https://issues.apache.org/jira/browse/YARN-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382171#comment-14382171
 ] 

Junping Du commented on YARN-3334:
----------------------------------

Thanks [~zjshen] for review and comments!
In v2, I corporate all of your comments above except one: replace 
TimelineEntity with ContainerEntity. I agree that the latter one sounds better. 
However, the test cannot pass locally if replacing 
{code}
          TimelineEntity entity = new TimelineEntity();
          entity.setId(containerId.toString());
          entity.setType(TimelineEntityType.YARN_CONTAINER.toString());
{code}
with:
{code}
          ContainerEntity entity = new ContainerEntity();
          entity.setId(containerId.toString());
{code}
Do we expect some info extra is necessary for ContainerEntity to set? If not, I 
suspect some bug (NPE, etc.) could be hidden in putEntity for ContainerEntity. 
If so, can we fix it separately? Add a TODO here though. 

> [Event Producers] NM start to posting some app related metrics in early POC 
> stage of phase 2.
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-3334
>                 URL: https://issues.apache.org/jira/browse/YARN-3334
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: YARN-2928
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-3334-demo.patch, YARN-3334-v1.patch, 
> YARN-3334-v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to