[ 
https://issues.apache.org/jira/browse/YARN-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382575#comment-14382575
 ] 

Sangjin Lee commented on YARN-3401:
-----------------------------------

Thanks for reminding me of that discussion. Yes, we definitely discussed that, 
and we said that only YARN daemons are allowed to post system entities. If any 
non-YARN daemons (e.g. AMs, clients, tasks, etc.) try to post YARN system 
entities they would be rejected.

That said, they can still refer to a YARN system entity. For example, if you're 
an MR AM then you might refer to the container id to post metrics for the 
container in which your tasks are running. So we need to be precise exactly 
what is disallowed.

bq. if so if we add a check @ Timelineclient will it impact NM from posting 
container metrics & entities ?

NM is a YARN daemon, so it should be able to post container metrics and 
entities with no issues.

> [Data Model] users should not be able to create a generic TimelineEntity and 
> associate arbitrary type
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3401
>                 URL: https://issues.apache.org/jira/browse/YARN-3401
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>
> IIUC it is possible for users to create a generic TimelineEntity and set an 
> arbitrary entity type. For example, for a YARN app, the right entity API is 
> ApplicationEntity. However, today nothing stops users from instantiating a 
> base TimelineEntity class and set the application type on it. This presents a 
> problem in handling these YARN system entities in the storage layer for 
> example.
> We need to ensure that the API allows only the right type of the class to be 
> created for a given entity type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to