[ 
https://issues.apache.org/jira/browse/YARN-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384285#comment-14384285
 ] 

Sangjin Lee commented on YARN-3047:
-----------------------------------

Took a quick look at the latest patch (v06). Looks good for the most part, but 
Field.java and TestTimelineReaderServer.java are missing the license. Could you 
please fix that quickly? The patch applies cleanly for me BTW.

bq. And I think max number of HttpServer threads should not be merely 10. Filed 
YARN-3407 for it

If I'm not mistaken, it looks like the number of threads can be controlled by 
HTTP_MAX_THREADS? And also by default jetty maxes out at 250? Wouldn't that be 
enough?

> [Data Serving] Set up ATS reader with basic request serving structure and 
> lifecycle
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-3047
>                 URL: https://issues.apache.org/jira/browse/YARN-3047
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: Timeline_Reader(draft).pdf, YARN-3047.001.patch, 
> YARN-3047.003.patch, YARN-3047.005.patch, YARN-3047.006.patch, 
> YARN-3047.02.patch, YARN-3047.04.patch
>
>
> Per design in YARN-2938, set up the ATS reader as a service and implement the 
> basic structure as a service. It includes lifecycle management, request 
> serving, and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to