[
https://issues.apache.org/jira/browse/YARN-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384899#comment-14384899
]
Karthik Kambatla commented on YARN-3304:
----------------------------------------
The approach in the "negative value" patch looks reasonable. Have a bunch of
nit-picks.
[~djp] - if you don't mind, I ll just post an update with the changes I have in
mind in the interest of time.
> ResourceCalculatorProcessTree#getCpuUsagePercent default return value is
> inconsistent with other getters
> --------------------------------------------------------------------------------------------------------
>
> Key: YARN-3304
> URL: https://issues.apache.org/jira/browse/YARN-3304
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Junping Du
> Assignee: Junping Du
> Priority: Blocker
> Attachments: YARN-3304-v2.patch, YARN-3304-v3.patch,
> YARN-3304-v4-boolean-way.patch, YARN-3304-v4-negtive-value-way.patch,
> YARN-3304.patch
>
>
> Per discussions in YARN-3296, getCpuUsagePercent() will return -1 for
> unavailable case while other resource metrics are return 0 in the same case
> which sounds inconsistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
