[ 
https://issues.apache.org/jira/browse/YARN-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385148#comment-14385148
 ] 

Ravindra Kumar Naik commented on YARN-3324:
-------------------------------------------

Thanks  [~raviprak] , [airbots] . I gave further thought after your comments. I 
think deleting the test image is not necessary considering the following, 
please see if it makes sense  
1. There will be overhead of downloading the image every time the test is run 
if we delete the image after running tests.
2. A generic centos image is used for test, so other application may use the 
same. The test may delete the dokcer image that was not even downloaded by test.
3. Even if we run the test multiple times, the image will not be downloaded 
every time it its already present ("docker pull" handles that) , so there will 
be no issue of accumulation of multiple test images. Single centos image takes 
210MB of disk space.


> TestDockerContainerExecutor should clean test docker image from local 
> repository after test is done
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3324
>                 URL: https://issues.apache.org/jira/browse/YARN-3324
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.6.0
>            Reporter: Chen He
>         Attachments: YARN-3324-branch-2.6.0.002.patch, 
> YARN-3324-trunk.002.patch
>
>
> Current TestDockerContainerExecutor only cleans the temp directory in local 
> file system but leaves the test docker image in local docker repository. It 
> should be cleaned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to