[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387091#comment-14387091
]
Arun Suresh commented on YARN-2962:
-----------------------------------
[~varun_saxena], Thanks for the patch. It looks pretty good.. also like the
extensive testing.
Couple of minor comments:
# The {{getLeafAppIdNodePath(Sting appId)}} and {{getLeafAppIdNodePath(Sting
appId, boolean createIfExists)}} looks pretty similar. They should probably be
refactored so that the former calls the later with {{createIfExists = false}} ?
# minor indentation errors (think you are using tabs) in {{loadRMAppState()}}
and {{removeApplicationStateInternal()}}
# in {{removeApplicationStateInternal()}}, cant you call
{{getLeafAppIdNodePath}} instead ?
Also was wondering, should we hard code the NO_INDEX_SPLITTING logic to 4 ?
Essentially, is it always guaranteed that sequence number will always be
exactly 4 digits ? I was thinking we just allow users to specify a split index.
If split index == size of seqnum, then don't split.. etc. Either way, I am ok
with the current implementation, just wondering if it was though of (And I
guess it might reduce some if then checks)
> ZKRMStateStore: Limit the number of znodes under a znode
> --------------------------------------------------------
>
> Key: YARN-2962
> URL: https://issues.apache.org/jira/browse/YARN-2962
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 2.6.0
> Reporter: Karthik Kambatla
> Assignee: Varun Saxena
> Priority: Critical
> Attachments: YARN-2962.01.patch
>
>
> We ran into this issue where we were hitting the default ZK server message
> size configs, primarily because the message had too many znodes even though
> they individually they were all small.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
