Vinod Kumar Vavilapalli commented on YARN-3304:

To summarize what happened so far
 - We had a configuration property to ResourceCalculatorProcessTree since for 
ever. But it was never usable in practice as ResourceCalculatorProcessTree 
itself was private and so could have gone through multiple 
compatible/incompatible changes.
 - I don't know of anyone outside of Hadoop MapReduce as 
ResourceCalculatorProcessTree is neither public nor documented.
    -- Besides Tez, that is.
 - 2.7.0 is the first release where we are trying to make it public: YARN-3296.
 - The API is only for developers to extend and create a new implementation. 
Users could never use it directly. MapReduce used it, but I think long term CPU 
millis for the container should come from YARN.
    -- Except, Tez is also using it

That said, let's do this
 - Recreate the old APIs and deprecate them.
 - Remark the getResourceCalculatorProcessTree() API as Public.

Here or another JIRA. Fine both ways.

> ResourceCalculatorProcessTree#getCpuUsagePercent default return value is 
> inconsistent with other getters
> --------------------------------------------------------------------------------------------------------
>                 Key: YARN-3304
>                 URL: https://issues.apache.org/jira/browse/YARN-3304
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Blocker
>             Fix For: 2.7.0
>         Attachments: YARN-3304-v2.patch, YARN-3304-v3.patch, 
> YARN-3304-v4-boolean-way.patch, YARN-3304-v4-negative-way-MR.patch, 
> YARN-3304-v4-negtive-value-way.patch, YARN-3304-v6-no-rename.patch, 
> YARN-3304-v6-with-rename.patch, YARN-3304-v7.patch, YARN-3304-v8.patch, 
> YARN-3304.patch, yarn-3304-5.patch
> Per discussions in YARN-3296, getCpuUsagePercent() will return -1 for 
> unavailable case while other resource metrics are return 0 in the same case 
> which sounds inconsistent.

This message was sent by Atlassian JIRA

Reply via email to