Junping Du commented on YARN-3304:

bq. We do not need to explicitly say so for each deprecated API. That said, in 
practice, we don't tend to remove deprecated APIs in the next release itself.
Agree. That sounds reasonable.

bq. Back to the patch. Junping Du, can you address these? "Also, can we 
deprecate (..) getCumulativeRssmem(int) and getCumulativeVmem(int)? "
Sure. [~vinodkv]. Incorporate this comments from [~kasha] in appendix-v3 patch. 

> ResourceCalculatorProcessTree#getCpuUsagePercent default return value is 
> inconsistent with other getters
> --------------------------------------------------------------------------------------------------------
>                 Key: YARN-3304
>                 URL: https://issues.apache.org/jira/browse/YARN-3304
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Blocker
>             Fix For: 2.7.0
>         Attachments: YARN-3304-appendix-v2.patch, 
> YARN-3304-appendix-v3.patch, YARN-3304-appendix.patch, YARN-3304-v2.patch, 
> YARN-3304-v3.patch, YARN-3304-v4-boolean-way.patch, 
> YARN-3304-v4-negative-way-MR.patch, YARN-3304-v4-negtive-value-way.patch, 
> YARN-3304-v6-no-rename.patch, YARN-3304-v6-with-rename.patch, 
> YARN-3304-v7.patch, YARN-3304-v8.patch, YARN-3304.patch, yarn-3304-5.patch
> Per discussions in YARN-3296, getCpuUsagePercent() will return -1 for 
> unavailable case while other resource metrics are return 0 in the same case 
> which sounds inconsistent.

This message was sent by Atlassian JIRA

Reply via email to