[ https://issues.apache.org/jira/browse/YARN-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389749#comment-14389749 ]
Vinod Kumar Vavilapalli commented on YARN-3318: ----------------------------------------------- Top level comments - It is not entirely clear how the ordering and limits work together - as one policy with multiple facets or multiple policy types. So we need to think more about what we expose right now -- let's split the patch that exposes this to the client side / web UI and in the API records into its own JIRA. We should do it a little later after the framework stabilizes. -- Capacity Scheduler Configuration also need more thought in terms of naming and layout. I think it's premature to support this as a publicly supportable configuration. But at the same time, to enable experimentation, we should simply not put in the public side of the code. - For future's sake and for discussion with FairScheduler folks, I think it is useful to split off CS changes into their own JIRA. We can strictly focus on the policy framework here. Quick comments on the policy stuff itself - I also like SchedulableEntity better. If not that, simply Schedulable works too - You add/remove applications to/from LeafQueue's policy but addition/removal of containers is an event. I think we should be consistent with these two. May be invent some sort of a notion of parent/child SchedulableEntities and make this generic? - The notion of a comparator doesn't make sense to an admin. It is simply a policy. Depending on how ordering and limits come together, they may become properties of a policy? > Create Initial OrderingPolicy Framework, integrate with CapacityScheduler > LeafQueue supporting present behavior > --------------------------------------------------------------------------------------------------------------- > > Key: YARN-3318 > URL: https://issues.apache.org/jira/browse/YARN-3318 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler > Reporter: Craig Welch > Assignee: Craig Welch > Attachments: YARN-3318.13.patch, YARN-3318.14.patch, > YARN-3318.17.patch, YARN-3318.34.patch, YARN-3318.35.patch, YARN-3318.36.patch > > > Create the initial framework required for using OrderingPolicies with > SchedulerApplicaitonAttempts and integrate with the CapacityScheduler. This > will include an implementation which is compatible with current FIFO behavior. -- This message was sent by Atlassian JIRA (v6.3.4#6332)