[ 
https://issues.apache.org/jira/browse/YARN-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391106#comment-14391106
 ] 

Wangda Tan commented on YARN-2740:
----------------------------------

[~Naganarasimha], 
Took a look, some comments:
1) Beyond "CommonNodeLabelsManager shouldn't persist labels on nodes when NM do 
heartbeat.", it shouldn't recover labels on nodes when RM restart. This is 
because RM configured centralized config, add some labels to nodes and change 
config to distributed then restart.

Need add tests to make sure RM restart will not recover labels on nodes when 
distributed configuration enabled.

2) isDistributedConfiguration should be a part of CommonNodeLabelsManager so 
that you don't need to get from configuration it in RMAdminService/RMWebService



> ResourceManager side should properly handle node label modifications when 
> distributed node label configuration enabled
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2740
>                 URL: https://issues.apache.org/jira/browse/YARN-2740
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>
>         Attachments: YARN-2740-20141024-1.patch, YARN-2740.20150320-1.patch, 
> YARN-2740.20150327-1.patch
>
>
> According to YARN-2495, when distributed node label configuration is enabled:
> - RMAdmin / REST API should reject change labels on node operations.
> - CommonNodeLabelsManager shouldn't persist labels on nodes when NM do 
> heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to