[ 
https://issues.apache.org/jira/browse/YARN-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393441#comment-14393441
 ] 

Junping Du commented on YARN-3334:
----------------------------------

Thanks [~zjshen] for review and comments!
bq. but I undo the some unnecessary change in TimelineClientImpl (which seems 
to be adde for code debugging).
I think that is necessary change. Previous message cannot tell too much info 
especially it return no different message between no response and response with 
failure. Also, error code should be log out even debug is not on because this 
is serious failure and should be reported in production environment. Thoughts?

> [Event Producers] NM TimelineClient life cycle handling and container metrics 
> posting to new timeline service.
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3334
>                 URL: https://issues.apache.org/jira/browse/YARN-3334
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: YARN-2928
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-3334-demo.patch, YARN-3334-v1.patch, 
> YARN-3334-v2.patch, YARN-3334-v3.patch, YARN-3334-v4.patch, 
> YARN-3334-v5.patch, YARN-3334-v6.patch, YARN-3334.7.patch
>
>
> After YARN-3039, we have service discovery mechanism to pass app-collector 
> service address among collectors, NMs and RM. In this JIRA, we will handle 
> service address setting for TimelineClients in NodeManager, and put container 
> metrics to the backend storage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to