Naganarasimha G R updated YARN-3044:
    Attachment: YARN-3044.20150406-1.patch

On after thoughts, i have changed  changed the approach for this jira (similar 
to the one mentioned by Zhijie ), because creating seperate stack was not only 
inducing too many changes but i was also skeptical that in future supporting 
removal of dependency from timelineservice project in RM project will again 
induce changes in seperate stack for V2 approach. 
So approach what i have taken is 
1> SMP will exist and SMP creates RMTimelineCollector. and RM will not be aware 
of RMTimelineCollector.
2> Seggregrate the V1 event handler code from SMP as TimelineV1Handler . 
(simpler to remove V1 support it in future )
3> add modifications in SMP such that TimelineV1Handler or RMTimelineCollector 
(V2) will be created based on configuration. Also appropriate Dispatchers are 
to be selected.

I have also incorporated the changes to support RMContainer metrics based on 
configuration (Junping's comments).

Pending tasks :
* Testcases for RMTimelinecollector is not completed, as i dint want to take 
the approach of TestDistributedShell as tests in it are mostly checking 
whether the required files are created but in case of TestRMTimelinecollector, 
we need to check whether the Entities are properly populated, which requires 
Reader API and it seems to be not finalized yet. Also even to make use 
FileSystemTimelineWriterImpl to test requires TimelineCollectorContext and 
hence the dependency on YARN-3390 
* As mentioned earlier AppConfig information is not completely available in RM 
side, hence currently have populated the Environment config available in RMApp. 
Shall i raise a new jira to support a method in TimelineClient interface to 
load Appconfig ?

> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>                 Key: YARN-3044
>                 URL: https://issues.apache.org/jira/browse/YARN-3044
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3044.20150325-1.patch, YARN-3044.20150406-1.patch
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.

This message was sent by Atlassian JIRA

Reply via email to