Li Lu commented on YARN-3431:

Hi [~zjshen], thanks for working on this! I reviewed your v2 patch, and the 
code LGTM. However, I'm a little bit confused about the big picture of this 
patch. In this patch you're setting up separate REST endpoints to post 
different types of timeline entities. However, all different REST endpoints 
have exactly the same internal logic, redirecting the incoming entity to the 
collector's putEntity. Are those endpoints just placeholders so that we can 
specialize each of them? Or else, I'm not sure about the motivation behind this 
(currently no description for this JIRA...). Could you please elaborate a 
little bit more on this?

BTW, I agree we need to specialize for different types of timeline entities, 
but maybe we need to do this on the collector/storage side? For storage layer 
design we need to write down the detailed timeline entities so specialization 
would be helpful. 

> Sub resources of timeline entity needs to be passed to a separate endpoint.
> ---------------------------------------------------------------------------
>                 Key: YARN-3431
>                 URL: https://issues.apache.org/jira/browse/YARN-3431
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3431.1.patch, YARN-3431.2.patch

This message was sent by Atlassian JIRA

Reply via email to