[
https://issues.apache.org/jira/browse/YARN-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483605#comment-14483605
]
Sidharta Seethana commented on YARN-3366:
-----------------------------------------
Thanks for the review, [~vvasudev] . Responses inline :
1. I'll fix this. This is an artifact of differences between trunk/branch-2
(repeated) 1. I think these are useful log lines that specify change in
behavior due to settings/system state etc. I'll clarify/improve the log
messages.
2. good catch, I'll fix it. Tests ran fine because WARN logging was enabled.
3. I'll fix the comments' location. The exception used to exist before but was
causing bootstrapping issues. I left it in there along with an explanation for
why it shouldn't be thrown. I'll remove it and modify comments.
4. Intellij warns me about this too - but I had left it in there for
clarity/consistency with the earlier code block - I believe it makes the code a
bit more readable. I would prefer to leave it in place.
5. I'll fix this
6. I'll fix this
7. why? compiler optimization?
8. I'll fix this.
9. I'll fix this.
10. I'll fix this.
11. I'll fix this - though I don't believe the merging always helps for
error/warn metrics
12. I'll fix this.
13. Not trivially, would refactoring launchContainer.
> Outbound network bandwidth : classify/shape traffic originating from YARN
> containers
> ------------------------------------------------------------------------------------
>
> Key: YARN-3366
> URL: https://issues.apache.org/jira/browse/YARN-3366
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-3366.001.patch, YARN-3366.002.patch
>
>
> In order to be able to isolate based on/enforce outbound traffic bandwidth
> limits, we need a mechanism to classify/shape network traffic in the
> nodemanager. For more information on the design, please see the attached
> design document in the parent JIRA.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
