Vinod Kumar Vavilapalli commented on YARN-3361:

Review of the tests
 - testNonExclusiveNodeLabelsAllocationIgnoreAppSubmitOrder
  --  -> testPreferenceOfNeedyAppsTowardsNodePartitions ?
  -- This doesn't really guarantee if app2 is getting preference or not. How 
about changing it to say app2 has enough requests to fill the entire node?
 - testNonExclusiveNodeLabelsAllocationIgnorePriority
  -- -> testPreferenceOfNeedyContainersTowardsNodePartitions ?
  -- Actually, now that I rename it that way, this may not be the right 
behavior. Not respecting priorities within an app can result in scheduling 
 - testLabeledResourceRequestsGetPreferrenceInHierarchyOfQueue: This is really 
 - testNonLabeledQueueUsesLabeledResource
  -- -> testQueuesWithoutAccessUsingPartitionedNodes
  -- Also validate that the wait for non-labeled requests not getting allocated 
on non-partitioned nodes is only for one cycle through all nodes in the cluster
 - Let's move all these node-label related tests into their own test-case.
 - More tests?
  -- AMs with labeled requirement not getting allocated on non-exclusive 
  -- To verify that we are not putting absolute max-capacities on the 
individual queues when not-respecting-partitions

> CapacityScheduler side changes to support non-exclusive node labels
> -------------------------------------------------------------------
>                 Key: YARN-3361
>                 URL: https://issues.apache.org/jira/browse/YARN-3361
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3361.1.patch, YARN-3361.2.patch
> According to design doc attached in YARN-3214, we need implement following 
> logic in CapacityScheduler:
> 1) When allocate a resource request with no node-label specified, it should 
> get preferentially allocated to node without labels.
> 2) When there're some available resource in a node with label, they can be 
> used by applications with following order:
> - Applications under queues which can access the label and ask for same 
> labeled resource. 
> - Applications under queues which can access the label and ask for 
> non-labeled resource.
> - Applications under queues cannot access the label and ask for non-labeled 
> resource.
> 3) Expose necessary information that can be used by preemption policy to make 
> preemption decisions.

This message was sent by Atlassian JIRA

Reply via email to