Jian He commented on YARN-3348:

Thanks Varun, some comments:
- “Unable to fetach cluster metrics” - typo
- exceeding 80 Column limit,
    "Comma separated list of types to 
restrict applications, case sensitive(though the display is lower case)");
- the -rows, -cols options seems not having effect on my screen when I tried 
it, could you double check ?
- the ‘yarn top’ output is repeatedly showing up on terminal every $delay 
seconds. it’ll be better to only show that only once. 
- Does the patch only show root queue info ? should we show all queues info ?
- “F + Enter : Select sort field” ; may be use ’S’ for sorting ?
- “Memory seconds(in GBseconds” - missing “)”
- It seems a bit odd to have this method in a public API record. Do you know 
why hashcode is not correct without this method ?  Or we can just type cast it 
to GetApplicationsRequestPBImpl and use the method from there.  
// need this otherwise the hashcode doesn't get generated correctly

- for the caching in ClientRMService. Do you think we can do the cache on 
client side ? that’ll save RPCs, especially if we have many top commands 
running on client side.

> Add a 'yarn top' tool to help understand cluster usage
> ------------------------------------------------------
>                 Key: YARN-3348
>                 URL: https://issues.apache.org/jira/browse/YARN-3348
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: apache-yarn-3348.0.patch, apache-yarn-3348.1.patch
> It would be helpful to have a 'yarn top' tool that would allow administrators 
> to understand which apps are consuming resources.
> Ideally the tool would allow you to filter by queue, user, maybe labels, etc 
> and show you statistics on container allocation across the cluster to find 
> out which apps are consuming the most resources on the cluster.

This message was sent by Atlassian JIRA

Reply via email to