Xuan Gong commented on YARN-3347:

Thanks for the review.

bq. For comma-separated value, do we mean attempt number? If so, may be we 
should describe more explicitly here? Also, can we use 0 (instead of -1) for AM 
container of latest attempt. If so, all negative value here is illegal.

Added. I prefer to use -1 for the latest AM Container. 0 in the list/array is 
the first element.

bq. Missing ! before getConf()?


bq. Sounds like we are re-order the sequence of user's input which seems 
unnecessary to me. I would suggest to keep order from user's input or it could 
confuse people.


bq. Also, for method of run(String[] args), it looks very complexity for now. 
Can we do some refactor work there and put some comments inline?

Yes, it indeed added some logics. Added some comments.

> Improve YARN log command to get AMContainer logs as well as running 
> containers logs
> -----------------------------------------------------------------------------------
>                 Key: YARN-3347
>                 URL: https://issues.apache.org/jira/browse/YARN-3347
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: log-aggregation
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-3347.1.patch, YARN-3347.1.rebase.patch, 
> YARN-3347.2.patch, YARN-3347.2.rebase.patch
> Right now, we could specify applicationId, node http address and container ID 
> to get the specify container log. Or we could only specify applicationId to 
> get all the container logs. It is very hard for the users to get logs for AM 
> container since the AMContainer logs have more useful information. Users need 
> to know the AMContainer's container ID and related Node http address.
> We could improve the YARN Log Command to allow users to get AMContainer logs 
> directly

This message was sent by Atlassian JIRA

Reply via email to