Naganarasimha G R commented on YARN-3044:

Thanks for the review [~djp], had gone through your patches earlier, and had 
mentioned in my earlier comment
Testcases for RMTimelinecollector is not completed, as i dint want to take the 
approach of TestDistributedShell as tests in it are mostly checking whether the 
required files are created but in case of TestRMTimelinecollector, we need to 
check whether the Entities are properly populated, which requires Reader API 
and it seems to be not finalized yet. Also even to make use 
FileSystemTimelineWriterImpl to test requires TimelineCollectorContext and 
hence the dependency on YARN-3390
hence had withheld working on the test cases as most of it was work around 
solution. If its ok to test with file exists and have some default value in 
{{RMTimelineCollector.getTimelineEntityContext()}} and correct it when 
i/[~zjshen] work on  YARN-3390, then will go ahead finishing the test cases.
Also mainly wanted some inputs whether the approach taken to publish Entities 
in SystemMetricsPublisher for ATS v1 and ATSV2 is fine. 

> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>                 Key: YARN-3044
>                 URL: https://issues.apache.org/jira/browse/YARN-3044
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3044.20150325-1.patch, YARN-3044.20150406-1.patch
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.

This message was sent by Atlassian JIRA

Reply via email to