[ 
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490374#comment-14490374
 ] 

Jian He commented on YARN-3472:
-------------------------------

[~rohithsharma], thanks for the patch. Could you add a test case?

In TestDelegationTokenRenwer#testReplaceExpiringDelegationToken, after this 
check {code}// wait for the initial expiring hdfs token to be removed. {code}, 
we can add a simple check that the token is removed from allTokens.

> Possible leak in DelegationTokenRenewer#allTokens 
> --------------------------------------------------
>
>                 Key: YARN-3472
>                 URL: https://issues.apache.org/jira/browse/YARN-3472
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Rohith
>         Attachments: 0001-YARN-3472.patch
>
>
> When old token is expiring and being removed, it's not removed from the 
> allTokens map, resulting in possible leak. 
> {code}
> if (t.token.getKind().equals(new Text("HDFS_DELEGATION_TOKEN"))) {
>               iter.remove();
>               t.cancelTimer();
>               LOG.info("Removed expiring token " + t);
>             }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to