Steve Loughran commented on YARN-3471:

# all raised exceptions need to include the URL of the timeline server in them. 
Otherwise nobody will ever be able to track down the problem if its any
# you can actually test TimelineClient (or any Yarn service) in a 
try-with-resources clause, to get the service automatically stopped {{ Service 
extends Closeable}}, see

try(Timeline client = createClient()) {

> Fix timeline client retry
> -------------------------
>                 Key: YARN-3471
>                 URL: https://issues.apache.org/jira/browse/YARN-3471
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3471.1.patch
> I found that the client retry has some problems:
> 1. The new put methods will retry on all exception, but they should only do 
> it upon ConnectException.
> 2. We can reuse TimelineClientConnectionRetry to simplify the retry logic.

This message was sent by Atlassian JIRA

Reply via email to