[
https://issues.apache.org/jira/browse/YARN-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wangda Tan updated YARN-3361:
-----------------------------
Attachment: YARN-3361.10.patch
Hi [~vinodkv],
Thanks for your comments,
bq. You should have added a default assignContainers() respecting exclusivity.
That way a lot of test changes could have been avoided.
I understand your concerns about there're too much changes in tests, but I
think we shouldn't add a used-by-test-only method in CSQueue interface, and
it's better to keep tests use latest interface, to make sure necessary changes
on tests once we changed interface signature. So I prefer to keep it.
bq. AbstractCSQueue.hasPendingResourceRequest() can be package-private. And to
avoid confusion, mark its usage in the child classes as
super.hasPendingResourceRequests().
Done.
Uploaded latest patch. (ver.10)
> CapacityScheduler side changes to support non-exclusive node labels
> -------------------------------------------------------------------
>
> Key: YARN-3361
> URL: https://issues.apache.org/jira/browse/YARN-3361
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-3361.1.patch, YARN-3361.10.patch,
> YARN-3361.2.patch, YARN-3361.3.patch, YARN-3361.4.patch, YARN-3361.5.patch,
> YARN-3361.6.patch, YARN-3361.7.patch, YARN-3361.8.patch, YARN-3361.9.patch
>
>
> According to design doc attached in YARN-3214, we need implement following
> logic in CapacityScheduler:
> 1) When allocate a resource request with no node-label specified, it should
> get preferentially allocated to node without labels.
> 2) When there're some available resource in a node with label, they can be
> used by applications with following order:
> - Applications under queues which can access the label and ask for same
> labeled resource.
> - Applications under queues which can access the label and ask for
> non-labeled resource.
> - Applications under queues cannot access the label and ask for non-labeled
> resource.
> 3) Expose necessary information that can be used by preemption policy to make
> preemption decisions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
