[ 
https://issues.apache.org/jira/browse/YARN-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494521#comment-14494521
 ] 

Sangjin Lee commented on YARN-3437:
-----------------------------------

Thanks [~djp] for your comments!

I agree with most of your comments. This particular subtask generates a pretty 
simple model (just a straightforward conversion of YARN-2556) where each map 
task creates one app collector and simple entities. But we will add more test 
modes that will have different characteristics. For one, we will add a mode 
where it iterates over MR job history files and pump them into the timeline 
storage.

The number of mappers is a pretty useful way of controlling the parallelism of 
tests, and we can add more parameters to have finer-grained parallelism 
controls (one app collector manager having multiple app collectors, etc.).

bq. BTW, it has some duplicated code with YARN-2556 (like 
TimelineServerPerformance.java).
That's because I copied it (as mentioned in the description). :) I had to fix a 
few issues with the original patch there to get it going. Some appear to be 
unrelated to porting it to the timeline service v.2. I'll add some comments 
there to help it get committed.

> convert load test driver to timeline service v.2
> ------------------------------------------------
>
>                 Key: YARN-3437
>                 URL: https://issues.apache.org/jira/browse/YARN-3437
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: YARN-3437.001.patch
>
>
> This subtask covers the work for converting the proposed patch for the load 
> test driver (YARN-2556) to work with the timeline service v.2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to