[ 
https://issues.apache.org/jira/browse/YARN-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494939#comment-14494939
 ] 

Steve Loughran commented on YARN-3471:
--------------------------------------

bq. Make sense because in v2 the url can be changed. Log the url if exception 
happens when connecting the timeline server.

makes sense in v1 as people can misconfigure their URL. 

Oddly enough, I'm deep in trying to fix some timeline problems, and was about 
to add better diagnostics myself. I'd like to see this patch (or variant 
thereof) in branch-2

I'm linking this patch to YARN-3477, in which the TL client doesn't rethrow the 
underlying exception on a retry timeout. It should, as that preserves the most 
information.

# line 407: if e.getCause()==IOE, cast and throw rather than wrap-and-throw



> Fix timeline client retry
> -------------------------
>
>                 Key: YARN-3471
>                 URL: https://issues.apache.org/jira/browse/YARN-3471
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3471.1.patch, YARN-3471.2.patch
>
>
> I found that the client retry has some problems:
> 1. The new put methods will retry on all exception, but they should only do 
> it upon ConnectException.
> 2. We can reuse TimelineClientConnectionRetry to simplify the retry logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to