[ https://issues.apache.org/jira/browse/YARN-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wangda Tan updated YARN-3354: ----------------------------- Attachment: YARN-3354.2.patch Thanks [~jianhe] for review! bq. setRequiredNodeLabelExpression -> nodeLabelExpression Done bq. NMContainerStatus#getRequiredNodeLabelExpression returns “” by default, but ContainerTokenIdentifier#getRequiredNodeLabelExpression returns NO_LABEL; RMContainerImpl#getRequiredlNodeLabelExpression returns NO_LABEL; - we may just return “” for default Now makes them return NO_LABEL, since NO_LABEL is the default value for empty-node-label-expression as well bq. Test case: add validation for the recovered resourceUsage. Done bq. proto file change is missing. Done Attached new patch, ver.2 > Container should contains node-labels asked by original ResourceRequests > ------------------------------------------------------------------------ > > Key: YARN-3354 > URL: https://issues.apache.org/jira/browse/YARN-3354 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, capacityscheduler, nodemanager, resourcemanager > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-3354.1.patch, YARN-3354.2.patch > > > We proposed non-exclusive node labels in YARN-3214, makes non-labeled > resource requests can be allocated on labeled nodes which has idle resources. > To make preemption work, we need know an allocated container's original node > label: when labeled resource requests comes back, we need kill non-labeled > containers running on labeled nodes. > This requires add node-labels in Container, and also, NM need store this > information and send back to RM when RM restart to recover original container. -- This message was sent by Atlassian JIRA (v6.3.4#6332)